Skip to content

Improve MA0192 HasFlag detection for zero comparisons#1161

Merged
meziantou merged 1 commit into
mainfrom
meziantou/ma0192-improvement
May 18, 2026
Merged

Improve MA0192 HasFlag detection for zero comparisons#1161
meziantou merged 1 commit into
mainfrom
meziantou/ma0192-improvement

Conversation

@meziantou

Copy link
Copy Markdown
Owner

MA0192 currently catches (value & Flag) == Flag style checks, but it misses the common zero-comparison form used to test bit presence. This makes the rule inconsistent and leaves valid HasFlag simplifications unreported.

What changed

  • Extend MA0192 analyzer detection to support:
    • (value & Flag) == 0
    • (value & Flag) != 0
    • (value & Flag) is 0
    • (value & Flag) is not 0
  • Keep existing same-flag patterns (== Flag, != Flag, is Flag, is not Flag).
  • Restrict zero-based detections to single-bit enum members only (non-zero power-of-two values), so combined flags do not trigger diagnostics.
  • Update the code fix logic to preserve correct semantics for zero comparisons (== 0/is 0 -> !HasFlag, != 0/is not 0 -> HasFlag).
  • Add/extend tests for new positive and negative scenarios.
  • Update MA0192 documentation to describe the new supported patterns and single-bit constraint.

Notes for reviewers

The main non-obvious behavior is the single-bit guard for zero comparisons. This is intentional to avoid changing meaning for combined flag constants where HasFlag and != 0 are not equivalent.

Add support for (value & flag) compared to 0 for ==, !=, is, and is not patterns when the enum flag is a single non-zero bit. Keep existing same-flag patterns, update fixer negation semantics, extend tests, and document the new behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@meziantou meziantou enabled auto-merge (squash) May 18, 2026 15:22
@meziantou meziantou merged commit 903fad4 into main May 18, 2026
13 checks passed
@meziantou meziantou deleted the meziantou/ma0192-improvement branch May 18, 2026 15:25
This was referenced May 18, 2026
This was referenced Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant